This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Paravirt framebuffer backend tools [2/5]

To: Jeremy Katz <katzj@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Paravirt framebuffer backend tools [2/5]
From: Anthony Liguori <aliguori@xxxxxxxxxxxxx>
Date: Tue, 05 Sep 2006 12:57:12 -0400
Cc: aliguori <aliguori@xxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, sos22@xxxxxxxxxxxxx, Markus Armbruster <armbru@xxxxxxxxxx>
Delivery-date: Wed, 06 Sep 2006 02:22:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1157472715.7571.88.camel@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060904090150.GC4812@xxxxxxxxx> <1157472715.7571.88.camel@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20060728)
Jeremy Katz wrote:
On Mon, 2006-09-04 at 10:01 +0100, Steven Smith wrote:
+CFLAGS += -g -Wall
You shouldn't need to add -g here; Rules.mk handles it for you if
debug is set.

*nod*  -Wall gets set in Config.mk as well -- will nuke.

--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/tools/xenfb/keymapping.c  Sat Sep 02 15:19:25 2006 -0400
@@ -0,0 +1,141 @@
+#include <stdint.h>
+#include <gdk/gdkkeysyms.h>
+#include <linux/input.h>
+uint32_t gdk_linux_mapping[0x10000] = {
+       [GDK_a] = KEY_A,
This is kind of ugly.  Is there any chance it could be autogenerated?
Also, where did 0x10000 come from?

Also, depending on GTK just for the keymap table is a real pain.  Or
is it already required for libvncserver?

libvncserver requires GTK.  And I don't know that there's really any
good way to auto-generate it unfortunately.  I somehow expect that
0x10000 came from "it'll be big enough" but Anthony would have to
confirm :-)

That's the biggest that a GDK scan code can currently be. That way, we can use a simple indexed table.


Anthony Liguori

The mappings are unfortunately a bit of a fact of life since we have to
convert from what the X layer gets to what the kernel expects.  And the
two couldn't be farther from the same.  And then it's even more fun when
toolkits get involved.

Xen-devel mailing list