This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] block_sync bugfix & cleanup

To: "Jun Koi" <junkoi2004@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] block_sync bugfix & cleanup
From: "Andrew Warfield" <andrew.warfield@xxxxxxxxxxxx>
Date: Fri, 1 Sep 2006 13:28:16 -0700
Cc: Xen Developers <xen-devel@xxxxxxxxxxxxxxxxxxx>, jac90@xxxxxxxxx
Delivery-date: Fri, 01 Sep 2006 13:28:41 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=TboNWaSklNrcq8H0T0LMEWelBAb7OBrmHonG9+u1ksIrHTw00GwqPxc2q0P4Bys+17YejXCrQs8iNc0JvJTjxfjM1ZHdeKgIC+yxFKNSP/aDLo5oOjQPjDx5ld0Q/K0tU0eDpt/f1roq347bitv+3+Z30apwx94xWiEsB3LlFUE=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <fdaac4d50609011032i6ea52f92v27cc7d7b74ca1b6d@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <fdaac4d50609011032i6ea52f92v27cc7d7b74ca1b6d@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Jun,

  The sync disk hasn't received a lot of use (it's quite slow) and is
intended mostly as a simpledemontrator of writing disk plugins.  I'm
happy to take cleanups to error handling code, but would rather that
they also fix the call in tapdisk to actually handle the error
properly -- returning BLKIF_RSP_ERROR to the frontend if the io can't
be issued for whatever reason.

  Whitespace fixes are fine, but lets do them all at once and in a
separate patch from bug fixes.  I can take a look at this for the
entirety of the user blktap code next week.


On 9/1/06, Jun Koi <junkoi2004@xxxxxxxxx> wrote:
Hi Julian and Andrew,

This patch reindents some lines of block_sync.c and fixes a small bug.
Please apply.

Signed-off-by: Jun Koi <junkoi2004@xxxxxxxxx>

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>