WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: missing log_success_msg?

To: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: missing log_success_msg?
From: Sean Dague <japh@xxxxxxxxxx>
Date: Fri, 25 Aug 2006 15:57:14 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 25 Aug 2006 12:57:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060825190241.GI7563@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Ewan Mellor <ewan@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <20060825185833.GR904@xxxxxxxxxxxxxxx> <20060825190241.GI7563@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, Aug 25, 2006 at 08:02:41PM +0100, Ewan Mellor wrote:
> On Fri, Aug 25, 2006 at 02:58:33PM -0400, Sean Dague wrote:
> 
> > Where is log_success_msg bash function supposed to be coming from?  It is
> > used in /etc/init.d/xendomains, and at least on my FC5 test system doesn't
> > seem to exist anywhere.
> > 
> > root@nibbler:~> service xendomains start
> > xendomains already running (lockfile exists)/etc/init.d/xendomains: line 67:
> > log_success_msg: command not found
> > 
> > It only seems to appear in the xendomains script:
> > 
> > root@nibbler:~/code/xen-unstable> grep -r log_success_msg *
> > dist/install/etc/init.d/xendomains:             log_success_msg "
> > [${_SMSG[${_RC_RV}]}] "
> > tools/examples/init.d/xendomains:               log_success_msg "
> > [${_SMSG[${_RC_RV}]}] "
> > 
> > This seems like a simple cosmetic issue that should be corrected prior to
> > 3.0.3.
> 
> Well, since the script looks like this:
> 
>     if test -e /lib/lsb/init-functions; then
>         # LSB
>         . /lib/lsb/init-functions
>         echo_rc()
>         {
>             if test ${_RC_RV} = 0; then
>                 log_success_msg "  [${_SMSG[${_RC_RV}]}] "
>             else
>                 log_failure_msg "  [${_SMSG[${_RC_RV}]}] "
>             fi
>         }
> 
> I reckon someone expects it to be in /lib/lsb/init-functions.  Any
> distro code-monkeys out there?

Fwiw, /lib/lsb/init-functions exists on FC5, and looks like the following:


root@nibbler:~> cat /lib/lsb/init-functions 
#!/bin/sh

# LSB initscript functions, as defined in the LSB Spec 1.1.0

alias start_daemon="/etc/redhat-lsb/lsb_start_daemon"
alias killproc="/etc/redhat-lsb/lsb_killproc"
alias pidofproc="/etc/redhat-lsb/lsb_pidofproc"
alias log_success_msg="/etc/redhat-lsb/lsb_log_message success"
alias log_failure_msg="/etc/redhat-lsb/lsb_log_message failure"
alias log_warning_msg="/etc/redhat-lsb/lsb_log_message warning"


root@nibbler:~> cat /etc/redhat-lsb/lsb_log_message
#!/bin/bash

. /etc/init.d/functions

ACTION=$1
shift

case "$ACTION" in
  success)
        echo -n $*
        success "$*"
        echo
        ;;
  failure)
        echo -n $*
        failure "$*"
        echo
        ;;
  warning)
        echo -n $*
        warning "$*"
        echo
        ;;
  *)
        ;;
esac
exit 0


my bash-foo is nearly none, so any bash folks that understand why this might
be not working would be appreciated.

        -Sean

-- 
Sean Dague
IBM Linux Technology Center                     email: japh@xxxxxxxxxx
Open Hypervisor Team                           alt: sldague@xxxxxxxxxx

Attachment: pgp9BvoLMBOLl.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>