WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xentrace event mask for memory management class

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] xentrace event mask for memory management class
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Fri, 18 Aug 2006 13:59:11 +0100
Cc: INAKOSHI Hiroya <inakoshi.hiroya@xxxxxxxxxxxxxx>, keir.fraser@xxxxxxxxxxxx, Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>
Delivery-date: Fri, 18 Aug 2006 05:59:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44E543E2.5050906@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <44E543E2.5050906@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.1
> Since TRC_MEM is defined as 0x000af000 in xen/include/public/trace.h,
> TRC_MEM = TRC_SCHED | TRC_VMX.  I feel strange about this.  I do not
> think scheduling is a part of memory management.  Am I right?

Looks to me like it's probably a typo that hasn't been spotted before - well 
done.

> This patch defines TRC_MEM as an independent event mask.  In addition,
> xentrace accepts '-e mem' option so that it puts memory management
> events in trace buffers.  The manual page (xentrace.8) is also
> modified accordingly.
>
> Tested by compiling on x86 and ia64, booting Dom0 and DomU, taking a
> xentrace log with '-e mem' option.

Thanks for the thorough testing and for updating the man page!

The patch looks fine to me.

+1

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>