 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [NET] front: Fix features on resume when csum is off
| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Xen Development Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [NET] front: Fix features on resume when csum is off |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Wed, 16 Aug 2006 14:00:02 +0100 |
| Cc: | Anton Burtsev <aburtsev@xxxxxxxxxxxxx> |
| Delivery-date: | Wed, 16 Aug 2006 06:00:34 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20060816011122.GA22978@xxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcbBM+LYIVhiwi0nEdu/QAAKle7CWA== |
| Thread-topic: | [NET] front: Fix features on resume when csum is off |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 16/8/06 2:11 am, "Herbert Xu" <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > [NET] front: Fix features on resume when csum is off > > When the netfront driver is resumed the features are renegotiated with > the backend. However, I forgot take into account the status of the TX > checksum setting. When TX checksum is disabled by the user, we cannot > enable SG or TSO since both require checksum offload. This patch makes > xennet check the checksum setting before renegotiating SG or TSO. This seems a bit odd. Shouldn't it be up to the network stack to not use SG/TSO if it can't use them with a non-checksumming interface? What is the failure mode currently? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [Xen-users] kernel panic on x86 PAE, Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] Re: [NET] front: Fix features on resume when csum is off, Herbert Xu |
| Previous by Thread: | [Xen-devel] [NET] front: Fix features on resume when csum is off, Herbert Xu |
| Next by Thread: | [Xen-devel] Re: [NET] front: Fix features on resume when csum is off, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
