WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [PATCH] Re: [Xen-devel] [RFC] support console resolutions better tha

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [PATCH] Re: [Xen-devel] [RFC] support console resolutions better than 80x25
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Tue, 15 Aug 2006 08:52:16 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 14 Aug 2006 23:52:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C106788E.DDD%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C1067544.DCE%Keir.Fraser@xxxxxxxxxxxx> <C106788E.DDD%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>Also, the union in start_info would be clearer as (assuming this
doesn't
>change the offset/size of any fields, which I don't think it does):
> union {
>    struct {
>       console_mfn/evtchn
>    } normal;
>    struct {
>       con_info_ofs/size
>    } init;
> } domain;
>
>Apart from being clearer, the Sun compiler doesn't like anonymous
unions so
>we try to avoid them.

I know you suggested doing it that way, but since the amount of
follow-up changes (to account for the changed naming) would be
higher, I didn't want to do this ...

>By the way: please just send further patches against your previous
>mega-patch. :-)

... in the already too large patch. So it should probably be a
follow-up
adjustment...

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>