WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] shared_info size and padding fixes

To: "Tristan Gingold" <Tristan.Gingold@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>, "John Levon" <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] shared_info size and padding fixes
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 10 Aug 2006 10:31:41 +0200
Delivery-date: Thu, 10 Aug 2006 01:31:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200608101003.37572.Tristan.Gingold@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060809210528.GA31314@xxxxxxxxxxxxxxxxxxxx> <200608101003.37572.Tristan.Gingold@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>      DEFINE(IA64_SWITCH_STACK_SIZE, sizeof (struct switch_stack));
>>      DEFINE(IA64_CPU_SIZE, sizeof (struct cpuinfo_ia64));
>>      DEFINE(UNW_FRAME_INFO_SIZE, sizeof (struct unw_frame_info));
>> -    DEFINE(SHARED_INFO_SIZE, sizeof (struct shared_info));
>>
>>      BLANK();
>>      DEFINE(IA64_MCA_CPU_INIT_STACK_OFFSET, offsetof (struct
ia64_mca_cpu,
>
>Please, do not remove this define.  It is used to check the struct is
not 
>bigger than a page!

Checking this should be done with BUILD_BUG_ON() in a .c file, and
hence
not require an entry in asm-offsets.c.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel