WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-ia64-devel] Re: [Xen-devel] [PATCH RFC] fix noreboot behaviour on c

To: Muli Ben-Yehuda <muli@xxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-ia64-devel] Re: [Xen-devel] [PATCH RFC] fix noreboot behaviour on clean reboot(was: intended behaviour of noreboot)
From: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Date: Tue, 08 Aug 2006 06:30:46 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 07 Aug 2006 14:29:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060807121328.GD3802@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060806065053.GB3447@xxxxxxxxxxxxxxxxxx> <C0FCA7A8.90D%Keir.Fraser@xxxxxxxxxxxx> <20060807121328.GD3802@xxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

I tested Muil's patch on ia64.

The below is test results.
- Before patch
    reboot  ----> reboot
    halt    ----> reboot
    panic   ----> reboot

- After patch
    reboot  ----> reboot
    halt    ----> reboot
    panic   ----> reboot
    
This results is caused by calling EFI_RESET_SHUTDOWN in ia64's 
machine_halt(). Ia64's machine_halt require system reboot because
EFI_RESET_SHUTDOWN (used by ia64's machine_halt()) enter ACPI G2/S5
 or G3 state.

This is ia64 issue, I think Muli's patch is good. :-)

Best Regards,

Akio Takebe

>On Mon, Aug 07, 2006 at 08:17:44AM +0100, Keir Fraser wrote:
>> On 6/8/06 7:50 am, "Muli Ben-Yehuda" <muli@xxxxxxxxxx> wrote:
>> 
>> > Setting 'noreboot' on the Xen command line stops reboot(1) from
>> > working in dom0. Is this the intended behaviour? I would expect
>> > noreboot to only apply to reboots that are trigerred as a result of
>> > kernel panis or oopses.
>> 
>> Clean shutdown of domain0 could clear the noreboot flag in Xen.
>
>Itt's a bit too hacky that machine_restart() either restarts or halts,
>depends on opt_noreboot. How about something like this:
>
>- move code specific to dom0 out of domain_shutdown() into
>  dom0_shutdown()
>- dom0_shutdown() has the following semantics:
>  if reason is SHUTDOWN_poweroff: halt
>  if reason is SHUTDOWN_crash: halt if opt_noreboot is set, reboot
>  otherwise.
>  if reason is SHUTDOWN_reboot: reboot (regardless of noreboot)
>  if reason is anything else: halt if opt_noreboot is set, reboot
>  otherwise (preserve backward compatible behaviour).
>- I checked and PV Linux i386/x86-64 uses
>  SHUTDOWN_crash/SHUTDOWN_reboot appropriately to give the above
>  semantics.
>- since opt_noreboot is now referenced in common code, add definitions
>  for it for ia64 and ppc as well. Hooking it in in arch code is
>  simple - just parse the command line options and set opt_noreboot
>  appropriately.
>
>Tested on x86-64, comments appreciated!
>
>Cheers,
>Muli
>


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>