|
xen-devel
[Xen-devel] Re: [RFC PATCH 32/33] Add the Xen virtual network device dri
|
To: |
David Miller <davem@xxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [RFC PATCH 32/33] Add the Xen virtual network device driver. |
|
From: |
Chris Wright <chrisw@xxxxxxxxxxxx> |
|
Date: |
Tue, 18 Jul 2006 14:09:50 -0700 |
|
Cc: |
akpm@xxxxxxxx, zach@xxxxxxxxxx, jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.pratt@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ak@xxxxxxx, chrisw@xxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, Christian.Limpach@xxxxxxxxxxxx |
|
Delivery-date: |
Tue, 18 Jul 2006 14:09:29 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20060718.134219.48395353.davem@xxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20060718091807.467468000@xxxxxxxxxxxx> <20060718091958.414414000@xxxxxxxxxxxx> <20060718.134219.48395353.davem@xxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.4.2.1i |
* David Miller (davem@xxxxxxxxxxxxx) wrote:
> From: Chris Wright <chrisw@xxxxxxxxxxxx>
> Date: Tue, 18 Jul 2006 00:00:32 -0700
>
> > +#ifdef CONFIG_XEN_BALLOON
> > +#include <xen/balloon.h>
> > +#endif
>
> Let's put the ifdefs in xen/balloon.h not in the files
> including it.
>
> > +#ifdef CONFIG_XEN_BALLOON
> > + /* Tell the ballon driver what is going on. */
> > + balloon_update_driver_allowance(i);
> > +#endif
>
> Similarly let's define empty do-nothing functions in
> xen/balloon.h when the config option isn't set so we
> don't need to crap up the C sources with these ifdefs.
Yeah, sorry it's kept more as a reminder to me. Upstream Xen doesn't do
this, but this patchset doesn't support ballooning yet, so there just is
not xen/balloon.h in the set. When merging with upstream Xen there's
patch rejects either way, so I agree, better to just drop this since
it's just future placeholder.
thanks,
-chris
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home