WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH - proposed] XI Shadow Page Table Mechanism]

To: zhu <vanbas.han@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH - proposed] XI Shadow Page Table Mechanism]
From: "Robert Phillips" <rsp.vi.xen@xxxxxxxxx>
Date: Fri, 30 Jun 2006 08:24:31 -0400
Cc: Xen-devel@xxxxxxxxxxxxxxxxxxx, "Robert S. Phillips" <rphillips@xxxxxxxxxxxxxxx>
Delivery-date: Fri, 30 Jun 2006 05:24:53 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=KI5nfrV1yfuPYcJPfAHfUuRPsu/x4VFKmiuUOq6yGPGk2jTjON982YUH1TT9C2dgssKLre6VGaYM/qhI7/odV7ZrSJjPjd4nFk4lSNsP5/F6ciWutjQObkUIfLd4AJ01m83tvPjn+S83G5kSeaEf0TOVB5Hb7YaKEgLaPiSwl2I=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44A48E5C.8060609@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <44A3CA74.4000206@xxxxxxxxxxxxxxx> <44A3D3CE.3040408@xxxxxxxxxxxxxxx> <44A3E08B.9090103@xxxxxxxxx> <44A3E98B.9040602@xxxxxxxxxxxxxxx> <44A3F073.50305@xxxxxxxxxxxxxxx> <44A48E5C.8060609@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Han,
You are right again.  I have not seen this cause a problem but we'll certainly fix it.
-- rsp

On 6/29/06, zhu < vanbas.han@xxxxxxxxx> wrote:
Hi, Robert,
I found out another confusing code snippet:
in void xi_invl_mfn(struct domain *d, unsigned long mfn)
     if (ext && pfn < ext->large_page_aligned_size)

According to the code, it should be
     if (ext && (pfn>>SPT_ENTRIES_ORDER) < ext->large_page_aligned_size)

If I made any mistake, please point it out.
_______________________________________________________
Best Regards,
hanzhu


--
--------------------------------------------------------------------
Robert S. Phillips                          Virtual Iron Software
rphillips@xxxxxxxxxxxxxxx                Tower 1, Floor 2
978-849-1220                                 900 Chelmsford Street
                                                    Lowell, MA 01851
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel