WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 1/3] Output Virtual Block Device requests informa

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 1/3] Output Virtual Block Device requests information to /proc/xen/vbd
From: "Satoshi Uchida" <s-uchida@xxxxxxxxxxxxx>
Date: Thu, 22 Jun 2006 18:17:10 +0900
Delivery-date: Thu, 22 Jun 2006 02:17:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcaVTZ+kPkNsRuw/QCaj3wrQUPbQqQASMB1QABGGNvA=
 
Hi,

> I looked at the code, and it seems "oo" stands of "out of", which  
> indicates how much we were out of request (Xen supports up to 64 
> requests in queue)

Thanks.
It may be correct.

>Few minor comments:
>- The variable dom_io_info_wq is unused, should be removed.
>- printk("%s: out of memory\n", __FUNCTION__) should be used with 
>KERN_ERR

Thanks.
I want to review around these codes.


>I have one question: in your below output:
>
>> Domain 4 - oo        0  rd    18699  wr        2
>>  xvd 4  8:21 - oo        0  rd    18699  wr        2
>
>I notice that you output the domid with xvd (4), but in the above line, we 
>already had that information (Domain 4).
> So why you need to show the domid again?

VBD processes in domain0 runs as xvd threads.
These threads names "xvd [Domain name] [Major Number]:[Minor Number]".
So, I show same name inelligibly.
In addition, I think that total Information for each domain is added optionally.
Therefore, its informatin is needed in such time.


Thanks,
Satoshi UCHIDA



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel