This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] free the right 1st level page table page in map_

To: Muli Ben-Yehuda <muli@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] free the right 1st level page table page in map_pages_to_xen
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 31 May 2006 17:21:36 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 31 May 2006 09:23:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060531161452.GB6975@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060531161452.GB6975@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 31 May 2006, at 17:14, Muli Ben-Yehuda wrote:

I think there's a buglet in map_pages_to_xen(), although it's entirely
possible I'm mis-reading it. In the case where we end up replacing a
non-super-page 2nd level entry with a super-page entry, we should free
the page table page pointed to by the old entry, not the new entry
(which doesn't actually point to a 1st level page).

Here's an untested "obviously correct" patch.


 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>