This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] Mini-OS Makefile TARGET_ARCH becomes MINIOS_TARG

To: ramsdell@xxxxxxxxx (John D. Ramsdell)
Subject: [Xen-devel] Re: [PATCH] Mini-OS Makefile TARGET_ARCH becomes MINIOS_TARGET_ARCH
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 22 May 2006 14:20:39 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 22 May 2006 06:20:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <ogt3bf2qrkn.fsf_-_@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <ogtwtcg9j9g.fsf@xxxxxxxxxxxxxxx> <c3eb784636090763af47f3aec7327c4e@xxxxxxxxxxxx> <ogt3bf2qrkn.fsf_-_@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 22 May 2006, at 11:31, John D. Ramsdell wrote:

We fixed this for Xen itself some time ago. If there are other places
in the tree that do this (maybe minios?), please do provide a patch.

To facilitate cut-and-paste of portions of the Mini-OS Makefile into
other Makefiles, this patch renames TARGET_ARCH to MINIOS_TARGET_ARCH.

First, you renamed to MINIOS_TARGET_OS, not _ARCH, which makes no sense. Second, you added references to TARGET_ARCH and TARGET_MACH to rule patterns, which seems unnecessary and might have unwanted side effects.

 -- Keir

Xen-devel mailing list