WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Fix auto-ballooning of dom0 for HVM domains

To: "Charles Coffing" <ccoffing@xxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Fix auto-ballooning of dom0 for HVM domains
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Mon, 22 May 2006 16:51:10 +0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 22 May 2006 01:52:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZ7fv1V09QAVhv/SI+ATNVm1yZMUwB/GfxQ
Thread-topic: [Xen-devel] [PATCH] Fix auto-ballooning of dom0 for HVM domains
>From: Charles Coffing
>Sent: 2006年5月20日 3:59
>> On Thu, May 18, 2006 at 10:23 PM, in message
><A8F9FF3706D1A5479EF62192B976DB441C0594@xxxxxxxxxxxxxxx
>orp.intel.com>,
>"Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:
>> Hi, Charles
>>      Just one suggestion, for  xen- hvm- auto- balloon.diff, how
>about
>> change
>>              xc.domain_setmaxmem(self.domid, m)
>>
>> to
>>              xc.domain_setmaxmem(self.domid, self.info['memory']
>*
>1024)
>
>Ideally, yes, I would agree.  But later, in qemu, another
>increase_reservation() is called.  If I make the suggested change, I
>suspect that qemu will fail to get its memory.
>
>Or is this upper limit not checked when increase_reservation() is
>called from dom0?

BTW, could you please explain why following change is required:

+        given amount, also in KiB.  This is normally just mem, but if 
HVM is
+        supported, keep a little extra free."""
+        if 'hvm' in xc.xeninfo()['xen_caps']:
+            mem_kb += 4*1024;
+        return mem_kb

Why do you need to reserve extra memory even for domU as long as 
the platform supports hvm feature? 

P.S I'll send a patch to reverse this change for ia64, since balloon doesn't 
work for xen/ia64 yet and thus we have to allocate all memory at creation 
time.

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel