RE: [Xen-devel] [PATCH] - make qemu serial summagraphics settings a bitmore fluid

["Dugger, Donald D" <donald.d.dugger@xxxxxxxxx>]

Ben-

I like the idea but I don't understand how this patch can work:

1)  You never put a name into `serial_devices[]' for the summa port.
The loop in `main' that initializes the serial devices only calls
`qemu_chr_open' if there's a string name in `serial_devices'.  How did
you get this to work?

2)  Minor point, I don't see the need for the `serial_summa' array, a
simple integer that is initialized to -1 would accomplish the same
thing.  (I have this thing about wasting memory :-)

3)  Personally, I hate counting serial ports from 1, everybody knows
that computers count from 0.  I'd refer to it as which `ttyS' port to
use, starting from 0, but I'm willing to live with the COM terminology.

--
Don Dugger
"Censeo Toto nos in Kansa esse decisse." - D. Gale
Donald.D.Dugger@xxxxxxxxx
Ph: (303)440-1368 

>-----Original Message-----
>From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
>[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Ben Thomas
>Sent: Thursday, May 18, 2006 12:50 PM
>To: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: [Xen-devel] [PATCH] - make qemu serial summagraphics 
>settings a bitmore fluid
>
>Changeset 9967 made the qemu serial line Summagraphics support a little
>more flexible with respect to the COM line chosen.  This patch
>furthers that effort by removing the COM2 restriction.  This patch
>allows a "-summa n" command line option to qemu to specify which, if
>any, COM port should be using the Summagraphics protocols.
>
>Signed-off-by: Ben Thomas (ben@xxxxxxxxxxxxxxx)
>
>-- 
>---------------------------------------------------------------
>---------
>Ben Thomas                                         Virtual 
>Iron Software
>bthomas@xxxxxxxxxxxxxxx                            Tower 1, Floor 2
>978-849-1214                                       900 
>Chelmsford Street
>                                                    Lowell, MA 01851
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel