This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] PATCH: fix transparent virtualization issue

To: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Subject: Re: [Xen-devel] PATCH: fix transparent virtualization issue
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 17 May 2006 23:35:02 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 17 May 2006 15:40:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200605171317.25885.Tristan.Gingold@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200605171317.25885.Tristan.Gingold@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 17 May 2006, at 12:17, Tristan Gingold wrote:

this patch fixes a few transparent virtualization (ie running xenolinux on
bare platform) issues for xen/ia64.

Why not call xen_init() in the two places you added NULL check for xen_start_info? Especially in netfront -- you already call xen_init() in blkfront, so it seems weird not to do so in netfront. I see no reason not to call it in swiotlb.c too.

xen_init() is a pretty bad name by the way, seeing as it's called all over the place so it's not really initialising xen state at every call site. Given that it is used in most places for the caller to determine if you are running on Xen or not, why not call it running_on_xen() and have the initialisation on the first call just be a hidden side effect?

 -- Keir

Xen-devel mailing list