This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH]: kexec: framework and i386 (Take IX)

To: Horms <horms@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH]: kexec: framework and i386 (Take IX)
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 17 May 2006 11:10:45 +0100
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, Kazuo Moriwaka <moriwaka@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, Magnus Damm <magnus@xxxxxxxxxxxxx>, Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Delivery-date: Wed, 17 May 2006 03:11:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060517095213.GA31686@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060509091849.GA18206@xxxxxxxxxxxx> <ADC6736C7D0580takebe_akio@xxxxxxxxxxxxxx> <E4C678D592DC26takebe_akio@xxxxxxxxxxxxxx> <3c347db5fc144e0809c47b5efe8f6582@xxxxxxxxxxxx> <E5C678D85FF5AFtakebe_akio@xxxxxxxxxxxxxx> <12c36e8e9c573c900cd75f27b3d650d3@xxxxxxxxxxxx> <20060517024402.GA13874@xxxxxxxxxxxx> <20060517045322.GA24072@xxxxxxxxxxxx> <20060517095213.GA31686@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 17 May 2006, at 10:52, Horms wrote:

as promised earlier in the day, here is an update on the kexec/kdump
patch. The main changes are that SMP now works, and the dumping of
cpu registers for kdump has been moved into the hypervisor so as to
allow all CPUs to be captured, not just dom0's VCPUs.

Just looking at the generic patch:
 * Define KEXEC_CMD_* in your public kexec.h header, not xen.h.
* Don't pack all the different arg structs into a union -- the union will change in size if you ever add a bigger argument substructure, plus it's ugly. Split them out and put a comment by each KEXEC_CMD_* definition explaining what its argument parameter points at (see other header files like vcpu.h for an example). * Can you explain the need for all the changesin your kexec.patch? I guess there are some virt_to_phys address translations that need fixing up, but you also scatter a few hypercalls around in there (e.g., in base/cpu.c) -- can they not be handled more cleanly, or is kexec-on-xen somehow more special than kexec on any native architecture?

 -- Keir

Xen-devel mailing list