This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH] Rename init_IRQ to xen_init_IRQ

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] Rename init_IRQ to xen_init_IRQ
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Wed, 17 May 2006 15:55:55 +0800
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 17 May 2006 00:57:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZ5gIk5R99+Fk5cSbymQ+x1jZvcxwAAqx6g
Thread-topic: [PATCH] Rename init_IRQ to xen_init_IRQ
>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2006年5月17日 15:02
>On 17 May 2006, at 05:10, Tian, Kevin wrote:
>>      In the start, I moved init_IRQ to x86 io_apic.c which however
>> doesn't
>> work if user compiles xen0/xenU by different configuration file because
>> xenU doesn't compile io_apic by default. I'm not sure whether worthy
>> changing domU config file and then simply keep it within evtchn.c
>How about we declare it in evtchn.c always, but attribute((weak))? It's
>small and is marked __init anyway, so no space concern really. And
>it'll avoid putting yet another thing in CONFIG_X86?
>  -- Keir

That may work, but I'm not sure whether that style (attribute(weak)) is 
welcomed in kernel world. Previously I just saw such instances in user 
level, like libc. :-)

Especially, irq_ctx_init is also x86 specific and so it seems reasonable 
to put it into CONFIG_X86 and only leave real common stuff there...


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>