This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] RE: [Xen-changelog] [MINIOS] Fix the pagefault handler t

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] RE: [Xen-changelog] [MINIOS] Fix the pagefault handler to detect recursive faults.
From: "Petersson, Mats" <Mats.Petersson@xxxxxxx>
Date: Tue, 16 May 2006 21:01:11 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-changelog@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 16 May 2006 12:00:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZ5GdtAjK6uVmjQQF+zfRpg6e9fiAAAR82g
Thread-topic: [Xen-devel] RE: [Xen-changelog] [MINIOS] Fix the pagefault handler to detect recursive faults.
> -----Original Message-----
> From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx] 
> Sent: 16 May 2006 19:46
> To: Petersson, Mats
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; xen-changelog@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] RE: [Xen-changelog] [MINIOS] Fix the 
> pagefault handler to detect recursive faults.
> On 16 May 2006, at 19:47, Petersson, Mats wrote:
> >> +static int handling_pg_fault = 0;
> >
> > Surely this needs to be an array indexed by smp_processor_id(), or 
> > otherwise what happens if CPU0 page-faults when CPU1 is 
> currently in a 
> > page-fault?
> >
> > Or have I missed something that prevents this from ever happening?
> Mini-OS is a uniprocessor guest OS.

Ok. What confused me is that the defintion of read_cr2 is using
smp_processor_id(), but I guess it's just a constant value for minios
and the macro is a copy from something else... ;-)

>   -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>