This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel][PATCH] opps in blockback when missing media

To: "Ross Maxfield" <rmaxfiel@xxxxxxxxxx>
Subject: Re: [Xen-devel][PATCH] opps in blockback when missing media
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 16 May 2006 09:30:28 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 16 May 2006 01:35:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44686ECF.DD28.00D3.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4468C0AF.5010006@xxxxxxxxxxxxxxx> <44686ECF.DD28.00D3.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 15 May 2006, at 19:14, Ross Maxfield wrote:

I've created a patch to prevent an oops in Dom0 that occurs when a CD
device, specified as one of the 'hardrives' in the 'disk=' line of a
para-virtualized guest's def file, has no media when the guest is

The oops occurs in vbd.c when vbd_size() is called from connect() (in
xenbus.c) and the vbd pointer is really an error code that comes from
the failed open that occurred in vbd_create().

The first hunk is missing a line so it doesn't build, and the second hunk is not needed since there's a NULL check in the caller of connect(). I've fixed up and applied.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>