This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [Xen-changelog] Fix xentrace to initialise the trace

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Xen-changelog] Fix xentrace to initialise the trace buffers if they are not set up.
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 15 May 2006 17:30:37 +0100
Cc: sakaia@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 15 May 2006 09:31:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060515161915.GB11792@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1FfNdJ-0005Qn-Hd@xxxxxxxxxxxxxxxxxxxxx> <20060515161915.GB11792@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 15 May 2006, at 17:19, John Levon wrote:

In particular, don't do this. Only libbxc/xc_tbuf.c can include
xc_private.h. Why have you re-introduced this? Can you fix it back up
please to use get_size/get_mfn()?

I guess he was cribbing from xenmon/xenbaked.c which still includes xc_private.h. Your cleanup patch only touched that file very superficially.

I think there is some infrastructure common to both xentrace and xenmon that needs moving into xc_tbuf.c. That will remove duplicated code and mean that only libxenctrl needs to include xc_private.h and do grubby stuff with dom0 ops.

I look forward to patches from someone. :-)

 --- Keir

Xen-devel mailing list