This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [RFC PATCH 18/35] Support gdt/idt/ldt handling on Xen.

To: virtualization@xxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [RFC PATCH 18/35] Support gdt/idt/ldt handling on Xen.
From: Andi Kleen <ak@xxxxxxx>
Date: Wed, 10 May 2006 22:23:48 +0200
Cc: Chris Wright <chrisw@xxxxxxxxxxxx>, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Pavel Machek <pavel@xxxxxx>
Delivery-date: Wed, 10 May 2006 13:24:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060509072139.GB4150@xxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060509084945.373541000@xxxxxxxxxxxx> <20060509085155.177937000@xxxxxxxxxxxx> <20060509072139.GB4150@xxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.1
On Tuesday 09 May 2006 09:21, Pavel Machek wrote:
> Hi!
> > +static inline void load_TLS(struct thread_struct *t, unsigned int cpu)
> > +{
> > +#define C(i) get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + i] = 
> > t->tls_array[i]
> > +   C(0); C(1); C(2);
> > +#undef C
> > +}
> Why not use for loop here? gcc should be able to optimize it...

I don't think you can really blame the Xen people for that code - it's 
just the old code moved.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>