This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] paging_enabled and non-HVM guests

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] paging_enabled and non-HVM guests
From: Simon Kagstrom <simon.kagstrom@xxxxxx>
Date: Wed, 10 May 2006 20:35:25 +0200
Cc: xen-devel list <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 10 May 2006 11:35:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1147275754.27510.14.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <87wtcv5t9e.wl%simon.kagstrom@xxxxxx> <1147204426.19485.67.camel@xxxxxxxxxxxxxxxxxxxxx> <87r7325s83.wl%simon.kagstrom@xxxxxx> <1147272714.27510.8.camel@xxxxxxxxxxxxxxxxxxxxx> <1147275754.27510.14.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Wanderlust/2.15.2 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.4 (i386-pc-linux-gnu) MULE/5.0 (SAKAKI)
At Wed, 10 May 2006 10:42:34 -0500,
Hollis Blanchard wrote:
> To elaborate on my previous mail, it's not just CR0/paging at fault. For
> example, this use of page_array:
>     ...
>     l3p = l4[l4_table_offset(va)] >> PAGE_SHIFT;
>     l3p = page_array[l3p];
>     ...
> in map_domain_va_64() is obviously incorrect for paravirtualized
> domains.
> Also, I noticed there's another place that already tests VGCF_HVM_GUEST
> before paging_enabled(), which I guess is where you got the idea for
> your patch.

Actually, I found that afterwards :-).

> Simon, would you care to submit the more complete patch?

I'll see what I can do in the next few days!

// Simon

Xen-devel mailing list