This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] [vTPM] Not building vTPM frontend as module

To: Stefan Berger <stefanb@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] [vTPM] Not building vTPM frontend as module
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 10 May 2006 15:55:45 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 10 May 2006 07:56:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1147194526.421.4.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1147194526.421.4.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Even if it is unsafe to unload the module, there is still enormous benefit in allowing to build as a module as it allows the user to choose whether or not to load it in the first place!

I suggest you add __unsafe(THIS_MODULE) to the end of your module_init function, as we have done for netback and blkback. This will make it impossible for the user to unload the module, and print a message to the kernel log explaining why.

I'll apply the hunk of your patch that fixes the backend issue however.

 -- Keir

On 9 May 2006, at 18:08, Stefan Berger wrote:

This patch prevents the vTPM frontend to be built as module for now. An
'rmmod' causes some problems since the backend is still using the shared
This patch also fixes a problem in the backend.

Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>


Xen-devel mailing list