This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [RFC PATCH 00/35] Xen i386 paravirtualization support

To: "Martin J. Bligh" <mbligh@xxxxxxxxxx>
Subject: [Xen-devel] Re: [RFC PATCH 00/35] Xen i386 paravirtualization support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 9 May 2006 16:07:01 +0100
Cc: Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Delivery-date: Wed, 10 May 2006 04:50:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4460AC01.5020503@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "Martin J. Bligh" <mbligh@xxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <20060509084945.373541000@xxxxxxxxxxxx> <4460AC01.5020503@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/
On Tue, May 09, 2006 at 07:49:37AM -0700, Martin J. Bligh wrote:
> Congrats on getting this thrashed out. A few comments, most of which are
> boring style nits, but nonetheless ... will try to take a proper look
> later.
> General comment:
> Why is this style used:
> HYPERVISOR_foo_bar ?
> ie the capitalization of HYPERVISOR. Doesn't seem to fit with the rest
> of the kernel style.

It's also wrong.  There's more than one hypervisor and Xen shouldn't just
grab this namespace.  make it xen_ or xenhv_.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>