This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] fix for Failed VMEntry on VMX

To: David Lively <dlively@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix for Failed VMEntry on VMX
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 2 May 2006 17:19:14 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 02 May 2006 09:19:28 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44577378.9070303@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <44577378.9070303@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 2 May 2006, at 15:58, David Lively wrote:

I've been getting a "Failed VMEntry" when trying to boot a second
VMX guest (while the first one is still running, but is no longer in
real mode).  This patch fixes it.

Please `or' the vmread/vmwrite error returns together into an error variable and BUG_ON(error) just once at the bottom of the function. Also extend the comment a little to explicitly explain that this is working around a VMENTRY validation check.

Apart from that it looks good.

 -- Keir

Xen-devel mailing list