WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/ia64

To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/ia64
From: "Christian Limpach" <christian.limpach@xxxxxxxxx>
Date: Wed, 26 Apr 2006 10:19:49 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 26 Apr 2006 02:20:13 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=p6mGZSrAL6ZGMWDiW8e2q2ZkOzhCgrvi/4ABU4Ia/kmlxU9KfUfA1eA7yzXBtOMRosZfqfBn4T92tFTJdwEq5zfRvjR9N2I178YdRCQWMFbX425GcZRNtAlWYfHCTIynmpbUHgsqxhHRGpjBMHVfD4LYjBs1B6QZLcF+iirICpE=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060426023528.GB30680%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060425043052.GF26453%yamahata@xxxxxxxxxxxxx> <3d8eece20604250300j2f8579efkb535eba9f1b33ba1@xxxxxxxxxxxxxx> <20060426023528.GB30680%yamahata@xxxxxxxxxxxxx>
Reply-to: Christian.Limpach@xxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 4/26/06, Isaku Yamahata <yamahata@xxxxxxxxxxxxx> wrote:
On Tue, Apr 25, 2006 at 11:00:52AM +0100, Christian Limpach wrote:

> I also don't like the ifdef on dma_map_page since it requires you to
> #define it to something else to override it instead of implementing
> it.
>
> I prefer to have #if defined(__i386__) || defined(__x86_64__) (maybe
> with a comment stating !defined(__ia64__)) which will make it clear
> why these are ifdef'ed out.

I attached the updated patch.

Cool, although I'm still wondering about dma_declare_coherent_memory():
If you have your own dma_declare_coherent_memory(), don't you then
need to #define ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY so that you don't
get the default implementations in linux/dma-mapping.h?

Do you use the default dma_declare_coherent_memory() from
linux/dma-mapping.h and thus don't define
ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY?

   christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel