WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools/python pciif: fix some python format strin

To: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools/python pciif: fix some python format string operators
From: Ryan <hap9@xxxxxxxxxxxxxx>
Date: Mon, 10 Apr 2006 10:11:58 -0400
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 10 Apr 2006 07:12:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060410135248.GA8605@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1144676276.17916.13.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20060410135248.GA8605@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2006-04-10 at 14:52 +0100, Ewan Mellor wrote:
> 
> Applied, thanks.
> 
> Could you provide your patches as an attachment in the future?  Your patch got
> horribly mangled -- look how the plus signs wrap nicely onto the next line on
> an 80-column display, in the hunk below.
> 
> Cheers,
> 
> Ewan.
> 
> @@ -131,7 +131,7 @@
>                      nr_ports = size, allow_access = True)
>              if rc<0:
>                  raise VmError(('pci: failed to configure I/O ports on device 
> '
> +
> -                            '%s - errno=%d')&(dev.name,rc))
> +                            '%s - errno=%d')%(dev.name,rc))
> 

Sorry about that... I figured since this one was a small patch, I'd
inline it. But I'll send all future ones (small and large) as
attachments.

Ryan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>