Re: [Xen-devel] [PATCH 0/6] grantable and address conversion pat

Thanks for your comments.

On Mon, Apr 10, 2006 at 09:54:20AM +0100, Keir Fraser wrote:

> 1/6: We can't apply this as it would change the public 3.0 interface 
> for x86/64. Do you really need a long? If so, we'll have to make that 
> field arch-dependent in some way.

Perhaps a long is not needed for several years at least.

> 2/6: This is a poor fix. Either we should make the ring size fixed 
> (e.g., 4kB) rather than architectural page-sized, or grants should be 
> dynamically allocated in netfront rather than statically allocated. 
> This was done quite some time ago for blkfront, and would be the 
> preferred (although more difficult) fix here.

I'll go this direction.

> 4/6: Make the function that fills in map/unmap requests arch-specific? 
> At least filling in host_addr should be arch-specific -- we don't 
> really want to overload dev_bus_addr like this.

O.K. I'll introduce virt_to_host_addr() to xenLinux and make a new patch.
Is there any explanaition about host_addr and dev_bus_addr?
When I wrote this patch,I guessed that host_addr should have been
arch-indepedent and dev_bus_addr could be arch-depedent.
But it was wrong. I couldn't find any good explaination/usage samples
of these field.

-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH 0/6] grantable and address conversion patches, Keir Fraser

Next by Date:

[Xen-devel] Error compiling with CONFIG_PROFILING (xenoprof), Michael Paesold

Previous by Thread:

[Xen-devel] [PATCH 3/3] grant table and netfront clean up, Isaku Yamahata

Next by Thread:

Re: [Xen-devel] [PATCH 0/6] grantable and address conversion patches, Keir Fraser

Indexes:

[Date] [Thread] [Top] [All Lists]