| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
RE: [Xen-devel] [PATCH] enable modifying of registers from gdb
Hi Keir,
Here is a new updated patch with the changes as you suggested.
Patch diffstat:
tools/libxc/xc_ptrace.c | 383
++++++++++++++++++++-----------------
tools/libxc/xc_ptrace.h | 6
xen/arch/x86/domain.c | 2
xen/arch/x86/hvm/svm/svm.c | 7
xen/arch/x86/hvm/svm/vmcb.c | 17 -
xen/arch/x86/hvm/vmx/vmcs.c | 26 --
xen/arch/x86/hvm/vmx/vmx.c | 54 ++++-
xen/common/domain.c | 1
xen/include/asm-x86/hvm/hvm.h | 8
xen/include/asm-x86/hvm/svm/svm.h | 1
xen/include/asm-x86/hvm/vmx/vmcs.h | 2
11 files changed, 261 insertions(+), 246 deletions(-)
Signed-Off-by: Nitin A Kamble <nitin.a.kamble@xxxxxxxxx>
Thanks & Regards,
Nitin
------------------------------------------------------------------------
-----------
Open Source Technology Center, Intel Corp
>-----Original Message-----
>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: Wednesday, March 29, 2006 5:08 AM
>To: Kamble, Nitin A
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Ian Pratt
>Subject: Re: [Xen-devel] [PATCH] enable modifying of registers from gdb
>
>
>On 29 Mar 2006, at 03:56, Kamble, Nitin A wrote:
>
>> I have updated the code with more fixes/changes in the patch and
>> also cleaned up the map_domain_va code further. Now gdb is able to
get
>> guest memory correctly in various guest modes.
>
>Nitin,
>
>Most of the patch looks fine, except for your changes to setvcpucontext
>in domain.c.
>
>I think you should get rid of hvm_modify_guest_state() entirely
>(deleting both svm and vmx implementations) and replace the call to it
>in arch_set_info_guest() with a call to hvm_load_cpu_guest_regs().
>
>I would then expect that your patch in domain.c is unnecessary: it
>should work for you to call arch_set_info_guest() regardless of whether
>DOMF_debugging is set.
>
> -- Keir
gdbserver_setgegs_2M_pages_32bit_on_64bit_fix_3.patch
Description: gdbserver_setgegs_2M_pages_32bit_on_64bit_fix_3.patch
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home