WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [RFC PATCH 30/35] Add generic_page_range() function

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [RFC PATCH 30/35] Add generic_page_range() function
From: Nick Piggin <nickpiggin@xxxxxxxxxxxx>
Date: Thu, 23 Mar 2006 11:15:54 +1100
Cc: Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>
Delivery-date: Thu, 23 Mar 2006 18:05:27 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=N7C9rbWvKmAtv+4BD26jr/BPOTBRPDiMKNm5UVO6K96aQkRSa0IGx/QJEs/1OrX+qGKmzhb2MrdPzVmmcqyE3RjGp83rbV6pk6nOz4dtyVN3bkZCUIw+8M548tlXkp2zeKwrSf7ABQbRimT4nIU6A+2bdtxjup7ymurYQ2N0l60= ;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <503082446ce33efbf163ad2af63bb0e1@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060322063040.960068000@xxxxxxxxxxxxxxxxxx> <20060322063805.741915000@xxxxxxxxxxxxxxxxxx> <44213333.6030404@xxxxxxxxxxxx> <79fcd3fd1d13741c5d1cd3c6f5b326b9@xxxxxxxxxxxx> <503082446ce33efbf163ad2af63bb0e1@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1
Keir Fraser wrote:

On 22 Mar 2006, at 14:33, Keir Fraser wrote:

Okay, can you suggest a better one? That's the best I could come up with that wasn't long winded.


How about apply_to_page_range()?


That would be better.


secondly, I think you confuse our (confusing) terminology: the page
that holds pte_ts is not the pte_page, the pte_page is the page that
a pte points to


What should we call it? Essentially we want to be able to get the physical address of a PTE in some cases, and passing struct page pointer seemed the best way to be able to derive that. I can rename it to something else vaguely plausible if the only problem is the semantic clash with Linux's idiomatic use of pte_page.


Looks like pmd_page is correct?


Yes... although maybe you could just pass the 'pmd_t *'? That's
what a lot of the mm/memory.c code does.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>