WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-changelog] Added exception handler for ProtocolErro

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] Added exception handler for ProtocolError.
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Thu, 23 Mar 2006 10:24:42 -0600
Cc: xen-changelog@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 23 Mar 2006 16:26:09 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E1FMQAe-0001Fm-0M@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1FMQAe-0001Fm-0M@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mail/News 1.5 (X11/20060309)
Xen patchbot -unstable wrote:
# HG changeset patch
# User emellor@xxxxxxxxxxxxxxxxxxxxxx
# Node ID c1bb4eb565296bdb00aed84fcc877befbcebd8e9
# Parent  b55ca95fdc846a5db9f30ba1c5d065fe898f88e7
Added exception handler for ProtocolError.

Signed-off-by: Ewan Mellor <ewan@xxxxxxxxxxxxx>

diff -r b55ca95fdc84 -r c1bb4eb56529 tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py       Thu Mar 23 10:55:56 2006
+++ b/tools/python/xen/xm/main.py       Thu Mar 23 10:58:19 2006
@@ -1102,6 +1102,12 @@
             else:
                 err("Error connecting to xend: %s." % ex[1])
             sys.exit(1)
+        except xmlrpclib.ProtocolError, ex:
+            if os.geteuid() != 0:
+                err("Most commands need root access.  Please try again as 
root.")
+            else:
+                err("Error connecting to xend: %s." % ex.errmsg)
+            sys.exit(1)
         except SystemExit:
             sys.exit(1)
         except xmlrpclib.Fault, ex:

Hi Ewan,

ProtocolError's shouldn't happen. The case where os.geteuid() != 0 is a possibility (although I thought we had a check earlier for that?). However, if we are getting them for another reason, something's wrong.

What commands were you seeing this with? There may be a latent bug in the dispatch code that marshals exceptions...

Regards,

Anthony Liguori

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>