WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] RE: patch to test vbd loopback sharing issue

To: "Yu, Ping Y" <ping.y.yu@xxxxxxxxx>
Subject: Re: [Xen-devel] RE: patch to test vbd loopback sharing issue
From: Dan Smith <danms@xxxxxxxxxx>
Date: Fri, 17 Mar 2006 07:43:02 -0800
Cc: Daniel Stekloff <dsteklof@xxxxxxxxxx>, Xen Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ricardo C Gonzalez <ricardoz@xxxxxxxxxx>
Delivery-date: Fri, 17 Mar 2006 15:43:59 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <2BF508F394C196468CCBEC031320DCDFA9DF23@pdsmsx405> (Ping Y. Yu's message of "Fri, 17 Mar 2006 09:48:28 +0800")
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <2BF508F394C196468CCBEC031320DCDFA9DF23@pdsmsx405>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.4 (gnu/linux)
PY> Daniel, Thanks a lot for your patch. In fact, I have another
PY> solution for this problem, that is, we can force mode "w" to
PY> "r". I have tested this patch and it works quite well in today's
PY> xm-test report.  Please help me review this patch. :-)

AFAIK, qemu-dm does not honor the read-only flag from xend.  This has
a side effect of making the concurrent use checks go away, but it also
would indicate to someone that the disk image is read-only, which
would not be true.  So, since 'r' is not honored, 'w!' is more
appropriate, as it describes what is actually happening.

So, IMHO, Dan's patch should go into the tree.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx

Attachment: pgp4TgB109Uoz.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>