xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] xc_inflate_buffer fix

from [Keir Fraser]

[Permanent Link][Original]

To:	David Lively <dlively@xxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] xc_inflate_buffer fix
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Fri, 17 Mar 2006 10:38:09 +0000
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Fri, 17 Mar 2006 11:05:57 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<44185567.6070805@xxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<44185567.6070805@xxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx


On 15 Mar 2006, at 17:56, David Lively wrote:

  I notice some of my initrds are failing to gunzip:
ERROR: inflate failed, sts -5
  These same initrds work fine with Ben Thomas' original
patch introducing xc_{linux,hvm}_build_mem.  The checked-in
version changed some declarations from unsigned char * to
char *, breaking the output length computation in xc_inflate_buffer.
  This patch assumes you want to keep using the signed char *
for the interface, so it simply inserts a few casts to unsigned.
Tested lightly, but the bug is pretty obvious once you notice
the signedness change ...


Yep, my bad. Thanks.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] xc_inflate_buffer fix, David Lively [Xen-devel] Re: [PATCH] xc_inflate_buffer fix, David Lively Re: [Xen-devel] [PATCH] xc_inflate_buffer fix, Keir Fraser <=

Previous by Date:	[Xen-devel] Re: [RFC, PATCH 5/24] i386 Vmi code patching, Joshua LeVasseur
Next by Date:	Re: [Xen-devel] [RFC] VMI for Xen?, Keir Fraser
Previous by Thread:	[Xen-devel] Re: [PATCH] xc_inflate_buffer fix, David Lively
Next by Thread:	[Xen-devel] [PATCH] fix build with perfc_arrays enabled, David Lively
Indexes:	[Date] [Thread] [Top] [All Lists]