Re: [Xen-devel] [PATCH][XM-TEST] init xmtest report files

[Dan Smith <danms@xxxxxxxxxx>]

WM> Fix init of report file for runtest.sh

Good, this is definitely needed because people are accidentally
submitting duplicate results when they use the same logfile name with
runtest.sh multiple times.

> -       echo "*** case $casename from group $groupentered" >> $output
> +       echo "*** case $casename from group $groupentered" > $output
>         if [ -z "$testlist" ]; then
> -          echo "*** Running tests for case $casename" >> $output
> -          (cd tests/$casename && TEST_VERBOSE=1 make -k check) >> $output 
> 2>&1
> +          echo "*** Running tests for case $casename" > $output
> +          (cd tests/$casename && TEST_VERBOSE=1 make -k check) > $output 2>&1
>         else
> -          echo "*** Running tests $testlist from case $casename" >> $output
> -          (cd tests/$casename && TEST_VERBOSE=1 make -k check 
> TESTS="$testlist") >> $output 2>&1
> +          echo "*** Running tests $testlist from case $casename" > $output
> +          (cd tests/$casename && TEST_VERBOSE=1 make -k check 
> TESTS="$testlist") > $output 2>&1

By changing every one of the redirects to '>' instead of '>>', you
will clobber the output file each time, which means that only the last
test group will actually be reported in the log file!

How did this pass a sniff test?

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel