WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] - xc_core.c/xenctrl.h - refactor slightly to all

To: "Ben Thomas" <bthomas@xxxxxxxxxxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] - xc_core.c/xenctrl.h - refactor slightly to allow user specified output routines
From: NAHieu <nahieu@xxxxxxxxx>
Date: Tue, 14 Mar 2006 17:59:02 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 14 Mar 2006 09:00:02 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=qa/hBkwn5muyh3ye9cshZ2JzS4Lw7boJqHvOox6f92VISBdJddVPJ6sta/rcsJNtWjSNpcE2O+N9Mi5z0tmMK7BiVMUPiR/gl7RMWOlCQAEQC9naNzTMFNNxJ9LrKd4lMIvsIcO6vtGKX8I3Vkr5UadCmOQKAIb63EKO7vvlgO0=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <5d7aca950603140036l56d54e76xc9e72654d99e41e4@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4411F860.8090506@xxxxxxxxxxxxxxx> <5d7aca950603140036l56d54e76xc9e72654d99e41e4@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
This patch fixes the memory leak in xc_domain_dumpcore_via_callback.
It also get rid one parameter of copy_from_domain_page() function.

Thanks.
H

On 3/14/06, NAHieu <nahieu@xxxxxxxxx> wrote:
> It seems that there is a memory leak in xc_domain_dumpcore2 (renamed
> to xc_domain_dumpcore_via_callback() by Keir): you failed to
> free(page_array) it in the function?
>
>
> Thanks.
> H
>
> On 3/11/06, Ben Thomas <bthomas@xxxxxxxxxxxxxxx> wrote:
> > The existing xc_domain_dumpcore is very specific to disk/file based
> > output.  Refactor the code slightly to allow more user-specified
> > control.  This is done by adding a parallel xc_domain_dumpcore2 (naming
> > isn't always my strong suit), which allows the specification of a
> > callback routine and an opaque argument block.  The existing dumpcore
> > routine is modified to use the callback for all write operations and
> > to turn the single seek into a small write (it's for page alignment).
> >
> > I've also included a small test routine, testdump.c, which drives
> > both APIs and allows writing core to either a local disk file or
> > across a network.  And, I've included a sample network "catcher"
> > program that receives a cross-network dump from testdump.
> >
> > And, good news, this probably ends my current hacking/interest
> > in xc_domain_dumpcore.
> >
> >
> > Signed-off-by: Ben Thomas (bthomas@xxxxxxxxxxxxxxx)
> >
> > --
> > ------------------------------------------------------------------------
> > Ben Thomas                                         Virtual Iron Software
> > bthomas@xxxxxxxxxxxxxxx                            Tower 1, Floor 2
> > 978-849-1214                                       900 Chelmsford Street
> >                                                     Lowell, MA 01851
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> >
> >
> >
> >
>

Attachment: dumpcore.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>