WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] xm: cleanup sched-sedf and tests

To: Ryan Harper <ryanh@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] xm: cleanup sched-sedf and tests
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Sat, 11 Mar 2006 14:51:03 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sat, 11 Mar 2006 14:52:04 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20060310200640.GD14363@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060307234243.GH15536@xxxxxxxxxx> <20060310003937.GE16724@xxxxxxxxxxxxxxxxxxxxxx> <20060310200640.GD14363@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, Mar 10, 2006 at 02:06:40PM -0600, Ryan Harper wrote:

> - Reworked to use your match_domid suggestion and filtering
> - Aligned output and help to fit within 80 char limit
> - User now deals in milliseconds instead of nanoseconds
> - Fixed some missing parens in tests (I had pushed stale versions)
> - Updated tests to deal with period/slice/latency in ms
> 
> root@bebop:~/xm-test.sedf/tests/sedf # xm sched-sedf
> Name                              ID Period(ms) Slice(ms) Lat(ms) Extra Weight
> Domain-0                           0      20.0      15.0     0.0      1      0
> 
> -- 
> Ryan Harper
> Software Engineer; Linux Technology Center
> IBM Corp., Austin, Tx
> (512) 838-9253   T/L: 678-9253
> ryanh@xxxxxxxxxx
> 
> 
> diffstat output:
>  python/xen/xm/main.py                               |  107 
> +++++++++-----------
>  xm-test/tests/sedf/01_sedf_period_slice_pos.py      |    8 -
>  xm-test/tests/sedf/02_sedf_period_lower_neg.py      |    5 
>  xm-test/tests/sedf/03_sedf_slice_lower_neg.py       |    5 
>  xm-test/tests/sedf/04_sedf_slice_upper_neg.py       |    5 
>  xm-test/tests/sedf/05_sedf_extratime_pos.py         |    2 
>  xm-test/tests/sedf/06_sedf_extratime_disable_neg.py |    3 
>  7 files changed, 73 insertions(+), 62 deletions(-)
> 
> Signed-off-by: Ryan Harper <ryanh@xxxxxxxxxx>

Applied, thanks.

It would make my life a little easier if you would (preferably) use "hg export"
to create your patches and (definitely) attach your patches to your email as
a separate attachment, as opposed to including them inline in the body of the
email.  Patches tend to get mangled if you include them inline, as they get
word-wrapped, and using hg export means that the commit comment gets inserted
automatically, rather than me having to cut-and-paste that separately.

Cheers,

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel