| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH] clean up CFLAGS
On 9 Mar 2006, at 19:47, Keir Fraser wrote:
I'll take a look at applying some of these piecemeal. After a quick
browse I see that the miniterm Makefile is broken (it is intended to
be built and installed on the external box, not the Xen box, so HOSTCC
is probably right for it but the potentially cross-compiling CC is
definitely not), and the changes to vmxassist and hvmloader have no
effect and I see no reason to prefer them over what is there already.
No comment on the rest as yet...
The rest looked okay to me, except I'm not 100% sure about pulling the
optimisation level out to Config.mk. It means if things liek Xen itself
want to make a debug build, they'd have to strip out the passed-in
'-O?' option which is a pain. So I left that part of the patch out for
now. And I made -Wall unconditionally added to CFLAGS in Config.mk
instead of "?=". I don't think it can ever hurt?
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home