[Xen-devel] Re: [Xen-changelog] A few changes to the new 'guest

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] Re: [Xen-changelog] A few changes to the new 'guest handle' interface:
From:	Hollis Blanchard <hollisb@xxxxxxxxxx>
Date:	Fri, 3 Mar 2006 11:45:53 -0600
Delivery-date:	Fri, 03 Mar 2006 17:46:44 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<E1FEpHk-0006a3-4Z@xxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	IBM Linux Technology Center
References:	<E1FEpHk-0006a3-4Z@xxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	KMail/1.8.3

On Thursday 02 March 2006 09:00, Xen patchbot -unstable wrote:
> -long subarch_memory_op(int op, GUEST_HANDLE(void) arg)
> +long subarch_memory_op(int op, guest_handle(void) arg)

I don't like this. I think standard C convention is to name macros in all 
capital letters. Now it looks like "guest_handle" is a function call, which 
of course doesn't make any sense here...

-- 
Hollis Blanchard
IBM Linux Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [Xen-changelog] A few changes to the new 'guest handle'