WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [PATCH] fix x86_64 build with specified CFLAGS

from [Keir Fraser] [Permanent Link][Original]
To: Rik van Riel <riel@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix x86_64 build with specified CFLAGS
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 3 Mar 2006 14:27:58 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 03 Mar 2006 14:28:16 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.63.0603030913590.21052@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <Pine.LNX.4.63.0603021634240.27728@xxxxxxxxxxxxxxxxxxxxxx> <02c5656986afd3d0fa089ffcea214f1a@xxxxxxxxxxxx> <Pine.LNX.4.63.0603030913590.21052@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 

On 3 Mar 2006, at 14:17, Rik van Riel wrote:


Where would the -m64 come from in that case? Not from Config.mk...


tools/Rules.mk:

ifeq ($(XEN_TARGET_ARCH),x86_64)
CFLAGS  += -m64
LDFLAGS += -m64
endif
Those directories don't include tools/Rules.mk, instead they include the root Config.mk file directly. Anyway, I made a different fix for you, which is to completely ignore externally-supplied CFLAGS when building in those directories (the assumption being that the build target is special and the local Makefile knows best). 

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] [PATCH] gdbserver-xen: fix corefile access, Horms
Next by Date:  Re: [Xen-devel] [PATCH] Re: [Xen-ia64-devel] Help? Red Hat fails, Suse/Debian both work fine, Keir Fraser
Previous by Thread:  Re: [Xen-devel] [PATCH] fix x86_64 build with specified CFLAGS, Rik van Riel
Next by Thread:  [Xen-devel] [PATCH] VTPM_Tools - Bug Fixes, Scarlata, Vincent R
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy