xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] reworked lomount

from [Charles Coffing]

[Permanent Link][Original]

To:	<xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] reworked lomount
From:	"Charles Coffing" <ccoffing@xxxxxxxxxx>
Date:	Thu, 02 Mar 2006 14:21:06 -0500
Delivery-date:	Thu, 02 Mar 2006 19:21:51 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

This patch started out as fixing a warning (due to system()'s return
value not being used).  Then I realized if lomount functioned well it
could be a replacement for kpartx in domUloader (or whatever the
combined pygrub+domUloader story turns out to be), so I gave it a closer
look.

Changes:
- Fixed several overflows, off-by-one, and uninitialized variables.
- Added well-defined exit codes.
- Proper handling of system()'s return value.
- Errors parsing partition table cause it to stop now.
- etcetera...

Tested on 32 and 64 bit, with valgrind, with physical disks and disk
images.

Please apply to xen-unstable.

Signed-off-by: Charles Coffing <ccoffing@xxxxxxxxxx>

lomount.diff
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] reworked lomount, Charles Coffing <=

Previous by Date:	[Xen-devel] Daily Xen Builds, David F Barrera
Next by Date:	[Xen-devel] [PATCH ] don't compile HVM_DBG_LOG into xen by default, Li, Xin B
Previous by Thread:	[Xen-devel] minor patch for vmx.c ...., Himanshu Raj
Next by Thread:	[Xen-devel] [PATCH ] don't compile HVM_DBG_LOG into xen by default, Li, Xin B
Indexes:	[Date] [Thread] [Top] [All Lists]