Re: [Xen-devel] [PATCH][SVM] 32bit msr support/enable 64bit vlap

WARNING - OLD ARCHIVES

http://lists.xen.org/

To:

Aron Griffis <aron@xxxxxx>

Subject:

Re: [Xen-devel] [PATCH][SVM] 32bit msr support/enable 64bit vlapic

From:

Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>

Date:

Thu, 2 Mar 2006 08:28:27 +0000

Cc:

xen-devel@xxxxxxxxxxxxxxxxxxx

Delivery-date:

Thu, 02 Mar 2006 08:30:44 +0000

Envelope-to:

www-data@xxxxxxxxxxxxxxxxxxx

In-reply-to:

<20060302011031.GA4721@xxxxxxxxxxxxxxx>

List-help:

<mailto:xen-devel-request@lists.xensource.com?subject=help>

List-id:

Xen developer discussion <xen-devel.lists.xensource.com>

List-post:

<mailto:xen-devel@lists.xensource.com>

List-subscribe:

<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>

List-unsubscribe:

<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>

References:

<F35BBA9A7A4D684FBFCEA191F108E53911CD1E98@xxxxxxxxxxxxxxxxx> <20060302011031.GA4721@xxxxxxxxxxxxxxx>

Sender:

xen-devel-bounces@xxxxxxxxxxxxxxxxxxx


On 2 Mar 2006, at 01:10, Aron Griffis wrote:

+#ifdef __x86_64__
     HVM_DBG_LOG(DBG_LEVEL_2, "mode_do_msr_read: msr_content: %lx\n",
             msr_content);
+#else
+    HVM_DBG_LOG(DBG_LEVEL_2, "mode_do_msr_read: msr_content: %llx\n",
+            msr_content);
+#endif


Could these simply use %llx and get rid of the #ifdef?  %llx is 64-bit
on x86 and x86_64


Should be PRIu64. I can make that simple cleanup...

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH][SVM] 32bit msr support/enable 64bit vlapic, Woller, Thomas Re: [Xen-devel] [PATCH][SVM] 32bit msr support/enable 64bit vlapic, Aron Griffis Re: [Xen-devel] [PATCH][SVM] 32bit msr support/enable 64bit vlapic, Keir Fraser <=

Previous by Date:

[Xen-devel] [PATCH] gdbserver-xen: fix corefile access, Horms

Next by Date:

Re: [Xen-devel] Re: [PATCH] Xen Guest Kexec, Gerd Hoffmann

Previous by Thread:

Re: [Xen-devel] [PATCH][SVM] 32bit msr support/enable 64bit vlapic, Aron Griffis

Next by Thread:

[Xen-devel] Daily Xen Builds, David F Barrera

Indexes:

[Date] [Thread] [Top] [All Lists]