WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Clean up warning for page_alloc.c

Hi Kevin,

I researched whether the declaration defined in "mmzone.h" is used.
As a result, most of the declared definitions were needless
for "mmzone.h". The necessary definition was only one line of 
"#include <linux/topology.h>" if I invalidated some definitions of
"include/asm-ia64/linux-xen/linux/gfp.h". The details please see
"example1.diff".
Request for comment.

Hi all,

By the way, "MAX_ORDER" is used in the following files.
 - xen/include/asm-ia64/xen/asm/meminit.h
  -- line 42:#define ORDERROUNDDOWN(n)   ((n) & ~((PAGE_SIZE<<MAX_ORDER)-1))
 - xen/arch/ia64/xen/xenmem.c
  -- line 46:ASSERT(mpt_order <= MAX_ORDER);

I removed "mmzone.h", but did not become any compilation errors.
It is the reason why "ORDERROUNDDOWN" is not used in Xen/ia64.
When I compiled Xen, I didn't use debug option.
I think that a definition of "MAX_ORDER" should be declared in 
header files.
Request for comment, too.

Best regards,
 Kan

Masaki Kanno wrote:
>Hi Kevin,
>
>I will research whether the declaration defined in "mmzone.h" is used.
>
>Best regards,
> Kan
>
>Tian, Kevin wrote:
>>To me, it's more meaningful to change mmzone.h, because we're in 
>>xen world. Due to historical reason, still some of linux files are remained 
>>unchanged in xen/ia64, with most stuff 
>useless (like MMZONE below). 
>>It's only work around in early stage for compilation, and now time for 
>>us to remove most of them and create new header files specific to 
>>xen/ia64 if necessary. I think this can be the guideline when you're 
>>cleaning up with confliction seen. ;-)
>>
>>Thanks,
>>Kevin
>>
>>>-----Original Message-----
>>>From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>>[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Masaki Kanno
>>>Sent: 2006定2埖27晩 12:35
>>>To: xen-devel@xxxxxxxxxxxxxxxxxxx; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>>>Subject: [Xen-devel] [PATCH] Clean up warning for page_alloc.c
>>>
>>>Hi all,
>>>
>>>I clean up warning in xen/ia64.
>>>The "MAX_ORDER" is redefined as I show below it.
>>>I didn't change the Linux original code "mmzone.h" and thought
>>>to change a local definition in "page_alloc.c".
>>>This patch changes a local definition from "MAX_ORDER" to
>>>"XEN_MAX_ORDER".
>>>
>>>page_alloc.c:222:1: warning: "MAX_ORDER" redefined
>>>In file included from
>>>/home/kanno/xen-ia64-unstable.hg/xen/include/asm-ia64/linux-xen/linux/gfp.h:
>>>7,
>>>                 from
>>>/home/kanno/xen-ia64-unstable.hg/xen/include/asm/mm.h:6,
>>>                 from
>>>/home/kanno/xen-ia64-unstable.hg/xen/include/linux/mm.h:79,
>>>                 from
>>>/home/kanno/xen-ia64-unstable.hg/xen/include/asm-ia64/linux-xen/asm/uacc
>>>ess.h:39,
>>>                 from
>>>/home/kanno/xen-ia64-unstable.hg/xen/include/asm/domain.h:143,
>>>                 from
>>>/home/kanno/xen-ia64-unstable.hg/xen/include/xen/sched.h:15,
>>>                 from page_alloc.c:28:
>>>/home/kanno/xen-ia64-unstable.hg/xen/include/asm-ia64/linux/mmzone.h:19:
>>>1: warning: this is the location of the previous
>>>definition
>>>
>>>Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>>>
>>>Best regards,
>>> Kan
>>
>>
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel
>

Attachment: example1.diff
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>