WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH][discuss] evtchn race condition

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH][discuss] evtchn race condition
From: "Woller, Thomas" <thomas.woller@xxxxxxx>
Date: Mon, 27 Feb 2006 17:05:16 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 27 Feb 2006 23:06:04 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcY5+1goMniAdwr9TkykY5OfU61KGwB9kjtQ
Thread-topic: [PATCH][discuss] evtchn race condition
Keir Fraser wrote:
> It looks as though the patch probably disables blocking on
> halt entirely, since you unconditionally set
> evtchn_pending_sel and evtchn_upcall_pedning on exit from
> hvm_wait_io. This then causes you to immediately exit from
> hvm_safe_block (since the pending_sel and upcall_pending will
> always both be != 0). Replacing your patch with one that
> simply removes the call to hvm_safe_block() from
> svm_vmexit_do_hlt() would I expect have the same effect (may be worth
> confirming?). 
Yes - you are correct. 
removing hvm_safe_block() from the hlt function alleviates the issue
also.

Attached is simple patch to remove hvm_safe_block() as a tmp solution.

Since this is only an SVM file modification, should not affect VT code
path.

Can you apply until final solution is found?
Applies cleanly to 8991.

Tom

Signed-off-by: Tom Woller <thomas.woller@xxxxxxx>

Attachment: svm_tmp_evtchn_fix.patch
Description: svm_tmp_evtchn_fix.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] RE: [PATCH][discuss] evtchn race condition, Woller, Thomas <=