WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86-64 linux: another adjustment to vmalloc faul

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86-64 linux: another adjustment to vmalloc fault handling
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Fri, 17 Feb 2006 12:22:14 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 17 Feb 2006 11:33:27 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <70f7092ddafe4fa9a96ebfd770ad2ed1@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <43F5B5CB.76F0.0078.0@xxxxxxxxxx> <70f7092ddafe4fa9a96ebfd770ad2ed1@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 17.02.06 12:05:13 >>>
>
>On 17 Feb 2006, at 10:38, Jan Beulich wrote:
>
>> Changeset 8847 improved things, but doesn't generally work. We namely 
>> experienced problems (when we originally tried the
>> same change) with accesses to machine_to_phys_mapping, which (in 
>> mfn_to_pfn) is specifically allowed to fault. Hence
>> there should not be attempts to fix up faults within the hypervisor 
>> range (as for any page table entries obtained there
>> no m2p translation exists for the guest, resulting in bogus physical 
>> addresses getting used for further fault
>> processing, frequently leading to nested faults).
>
>But machine_to_phys_mapping == 0xffff800000000000 while
>PAGE_OFFSET == HYPERVISOR_VIRT_END == 0xffff880000000000.
>
>So the patch doesn't really change anything, and 
>machine_to_phys_mapping lives below both PAGE_OFFSET and 
>HYPERVISOR_VIRT_END anyway.

Oh, I'm sorry, I mixed up TASK_SIZE64 and PAGE_OFFSET (we had used the former 
initially, because it's being done
similarly on i386). Between PAGE_OFFSET and HYPERVISOR_VIRT_END I just found 
using the latter here more correct, as
PAGE_OFFSET is not required to live at HYPERVISOR_VIRT_END, but that should 
always be the boundary for checking.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>