WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [Patch] Illegal grant mapping makes domain zombie

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [Patch] Illegal grant mapping makes domain zombie
From: Kouya SHIMURA <kouya@xxxxxxxxxxxxxx>
Date: Mon, 13 Feb 2006 15:15:07 +0900
Delivery-date: Mon, 13 Feb 2006 06:27:06 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

I think I found a bug.
__gnttab_map_grant_ref() doesn't perform put_domain()
in some case of fail to map the granted page.
That is, the domain might become zombie when illegal grant mapping.

This patch fixed it.

Regards,
Kouya SHIMURA

Signed-off-by: Kouya SHIMURA <kouya@xxxxxxxxxxxxxx>

diff -r 1d36cca98fc3 xen/common/grant_table.c
--- a/xen/common/grant_table.c  Fri Feb 10 11:35:19 2006
+++ b/xen/common/grant_table.c  Mon Feb 13 14:02:40 2006
@@ -316,6 +316,7 @@
     spin_unlock(&rd->grant_table->lock);
     (void)__put_user(rc, &uop->status);
     put_maptrack_handle(ld->grant_table, handle);
+    put_domain(rd);
     return rc;
 }
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [Patch] Illegal grant mapping makes domain zombie, Kouya SHIMURA <=