xen-devel

[Top] [All Lists]

[Xense-devel] [PATCH] dom0_ops -EPERM not -EACCES?

from [Rusty Russell]

[Permanent Link][Original]

To:	xense-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xense-devel] [PATCH] dom0_ops -EPERM not -EACCES?
From:	Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date:	Thu, 24 Nov 2005 12:35:42 +1100
Cc:	Xen Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Tue, 07 Feb 2006 09:09:58 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xense-devel-request@lists.xensource.com?subject=help>
List-id:	"A discussion list for those developing security enhancements for Xen." <xense-devel.lists.xensource.com>
List-post:	<mailto:xense-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xense-devel>, <mailto:xense-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xense-devel>, <mailto:xense-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xense-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hi all,

        dom0_ops return -EACCES when the interface version in wrong.  I think
that an acm failure is closer to being non-priv'ed, which returns
-EPERM.  Wouldn't want dom0 tools to report they were the wrong version
just because ACM limited some operation, surely?

Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> (authored)

diff -r e2d1c88d50f7 xen/common/dom0_ops.c
--- a/xen/common/dom0_ops.c     Thu Nov 24 00:55:37 2005
+++ b/xen/common/dom0_ops.c     Thu Nov 24 12:31:37 2005
@@ -102,7 +102,7 @@
         return -EACCES;
 
     if ( acm_pre_dom0_op(op, &ssid) )
-        return -EACCES;
+        return -EPERM;
 
     spin_lock(&dom0_lock);
 

-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


_______________________________________________
Xense-devel mailing list
Xense-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xense-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xense-devel] [PATCH] dom0_ops -EPERM not -EACCES?, Rusty Russell <=

Previous by Date:	[Xen-devel] xencomm address space API, Hollis Blanchard
Next by Date:	Re: [Xen-devel] remote xend - howto connect??, Michael Mey
Previous by Thread:	[Xen-devel] xencomm address space API, Hollis Blanchard
Next by Thread:	[Xen-devel] [PATCH][RESEND] fix two pygrub problems, John Levon
Indexes:	[Date] [Thread] [Top] [All Lists]