WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Build failure on i386 fedora core 4

To: "Kamble, Nitin A" <nitin.a.kamble@xxxxxxxxx>
Subject: Re: [Xen-devel] Build failure on i386 fedora core 4
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>
Date: Mon, 30 Jan 2006 23:38:10 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 30 Jan 2006 22:47:46 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E305A4AFB7947540BC487567B5449BA8094A6D40@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E305A4AFB7947540BC487567B5449BA8094A6D40@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Mon, Jan 30, 2006 at 01:52:07PM -0800, Kamble, Nitin A wrote:
> I am observing xen-unstable build failing on i386 FC4, as seen bellow.
> mm.c:1975: warning: ?mapcache.pfn? may be used uninitialized in this
> function
> 
> mm.c:1975: warning: ?mapcache.va? may be used uninitialized in this
> function

that's a bogus gcc4 warning. the variable is fine and not used
uninitialized, i checked.

I think just not using -Werror for gcc4 is a much better alternative, cf
following patch.

diff -r 690fc13948db xen/arch/x86/Rules.mk
--- a/xen/arch/x86/Rules.mk     Mon Jan 30 13:35:43 2006 +0100
+++ b/xen/arch/x86/Rules.mk     Mon Jan 30 22:40:33 2006 +0000
@@ -8,7 +8,7 @@
 pae ?= n
 
 CFLAGS  += -nostdinc -fno-builtin -fno-common -fno-strict-aliasing
-CFLAGS  += -iwithprefix include -Wall -Werror -Wno-pointer-arith -pipe
+CFLAGS  += -iwithprefix include -Wall -Wno-pointer-arith -pipe
 CFLAGS  += -I$(BASEDIR)/include 
 CFLAGS  += -I$(BASEDIR)/include/asm-x86/mach-generic
 CFLAGS  += -I$(BASEDIR)/include/asm-x86/mach-default
@@ -55,3 +55,7 @@
 $(error gcc-3.1.x unsupported - upgrade to at least gcc-3.2.x)
 endif
 endif
+ifneq ($(call gcc-ver,1),4)
+# gcc 4 have lots of spurious warnings, don't -Werror
+CFLAGS += -Werror
+endif

-- 
Vincent Hanquez

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>