WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Tue, 3 Jan 2006 20:47:41 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 03 Jan 2006 12:52:53 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcYPh0pjpPSedMOFQbOEz3h9ELBvtwA2S7Iw
Thread-topic: [Xen-devel] [PATCH] rename VMX option lapic to apic, and pass it to xen by hvm_info_table
>> Rename VMX option name lapic to apic, and pass it to xen by
>> hvm_info_table.
>> Previous we pass it to xen by guest vcpu context ECX register, now we
>> unify to use hvm_info_table.
>>
>> Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx>
>
>I like the name 'lapic' rather than 'apic' as it explicitly 
>disambiguates from 'ioapic'. And it's only one more character.
>

In current implementation, if 'lapic=1', both lapic and ioapic are
enabled for VMX guest, and this is what we prefer.
VMX guest has 3 PIC/APIC modes:
1. no lapic and ioapic, only PIC, and this is the default option.
2. both lapic and ioapic, enabled by 'lapic=1' in VMX config file.
3. only lapic and PIC, no ioapic. No such option, but VMX guest can only
use lapic by not using its ioapic.
This is the reason why I made this change.


>Placing the hvm info definitions in public/io/ioreq.h is not right. It 
>probably needs its own header file. How about a new subdirectory 
>include/public/hvm, containing hvm_info.h, ioreq.h and vmx_assist.h?
>

Yes, I like this new directory for VMX guest using, we do have some
structures defined twice.
-Xin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel