WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3/3] Some "make check" tests for xen/common

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/3] Some "make check" tests for xen/common
From: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
Date: Sun, 11 Dec 2005 10:15:00 +1100
Cc: Xen-Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sat, 10 Dec 2005 23:16:29 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4399A84A.4010104@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Anthony Liguori <aliguori@xxxxxxxxxx>, Xen-Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <20051209055625.GU25348@xxxxxxxxxxxxxxxxxx> <4399A84A.4010104@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, Dec 09, 2005 at 09:52:42AM -0600, Anthony Liguori wrote:
> Hi Tony,

Hi Anthony,
 
> I've been trying out the make check/fullcheck and I'm very impressed!  I 
> hope it gets pulled into the tree soon.
> 
> Two suggestions though, for patches this large, it would help to either 
> attach it to the original mail or provide a url to it.  inlining is nice 
> for review but a pain to pull out and apply to a tree.

Will do for next time.
 
> Also, with the latest unstable (8311:53cff3f88e45) the patches fail to 
> build (on xen/common/test/test_event_channel.c) because it cannot find 
> the include file <public/event_channel.h> in the #include 
> "../event_channel.c".  I was able to work around this by adding 
> -I../../include to the build rule in the Makefile.

Thanks for the feedback.  

There was a typo in patch 1/3.  It created public/event_chnnel.h instead
of public/event_channel.h.
Sorry.

The patch below can be applied on top of the other 3 to build a working
test.

--- xen-unstable.hg/xen/test/Makefile~  2005-12-11 10:05:58.000000000 +1100
+++ xen-unstable.hg/xen/test/Makefile   2005-12-11 10:06:01.000000000 +1100
@@ -1,4 +1,4 @@
-LINKS:=asm/types.h asm/uaccess.h asm/system.h asm/desc.h xen/config.h 
xen/types.h xen/errno.h xen/bitmap.h xen/bitops.h xen/lib.h xen/spinlock.h 
xen/time.h xen/string.h xen/init.h xen/sched.h xen/smp.h xen/perfc.h 
xen/softirq.h xen/ac_timer.h xen/keyhandler.h xen/mm.h public/acm.h 
public/acm_ops.h xen/event.h xen/trace.h xen/console.h asm/shadow.h 
public/sched_ctl.h acm/acm_hooks.h xen/domain.h xen/domain_page.h 
asm/debugger.h public/dom0_ops.h public/sched.h public/vcpu.h xen/irq.h 
asm/current.h public/xen.h public/event_chnnel.h
+LINKS:=asm/types.h asm/uaccess.h asm/system.h asm/desc.h xen/config.h 
xen/types.h xen/errno.h xen/bitmap.h xen/bitops.h xen/lib.h xen/spinlock.h 
xen/time.h xen/string.h xen/init.h xen/sched.h xen/smp.h xen/perfc.h 
xen/softirq.h xen/ac_timer.h xen/keyhandler.h xen/mm.h public/acm.h 
public/acm_ops.h xen/event.h xen/trace.h xen/console.h asm/shadow.h 
public/sched_ctl.h acm/acm_hooks.h xen/domain.h xen/domain_page.h 
asm/debugger.h public/dom0_ops.h public/sched.h public/vcpu.h xen/irq.h 
asm/current.h public/xen.h public/event_channel.h
 
 
 clean:


Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2006.linux.org.au/
   Jan 23-28 2006      The Australian Linux Technical Conference!


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>